quickboot-display: trigger weston on msm_dpu driver instead of card0 - #10
Open
Wenwen Fu (wenwfu) wants to merge 1 commit into
Open
quickboot-display: trigger weston on msm_dpu driver instead of card0#10Wenwen Fu (wenwfu) wants to merge 1 commit into
Wenwen Fu (wenwfu) wants to merge 1 commit into
Conversation
The udev rule matched KERNEL=="card0" to start weston, and the service ordered itself with Requires=/After=dev-dri-card0.device. The cardN numbering is assigned in probe order and is not guaranteed to be the display controller when more than one DRM device is present (e.g. a discrete GPU or a DP/HDMI bridge exposing its own card). Match on DRIVERS=="msm_dpu" instead -- the msm display-controller driver name, which is stable and board-independent across the msm display stack. DEVTYPE=="drm_minor" + KERNEL=="card[0-9]*" restrict the match to the card node itself, excluding renderD* and card*-<connector> child nodes that share the same driver. To keep an explicit ordering without the unstable cardN name, the rule also publishes SYSTEMD_ALIAS=/dev/dri/msm_dpu_card, exposing the node as the stable device unit dev-dri-msm_dpu_card.device; weston.service orders itself with Requires=/After=dev-dri-msm_dpu_card.device. Verified on rb3gen2-core-kit: card0's parent display-controller driver is msm_dpu, the rule matches only the card0 minor (not renderD128 or the DP/HDMI connector nodes), the alias device unit comes up active, and the service loads with the alias dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Signed-off-by: Wenwen Fu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The udev rule matched KERNEL=="card0" to start weston, and the service ordered itself with Requires=/After=dev-dri-card0.device. The cardN numbering is assigned in probe order and is not guaranteed to be the display controller when more than one DRM device is present (e.g. a discrete GPU or a DP/HDMI bridge exposing its own card).
Match on DRIVERS=="msm_dpu" instead -- the msm display-controller driver name, which is stable and board-independent across the msm display stack. DEVTYPE=="drm_minor" + KERNEL=="card[0-9]" restrict the match to the card node itself, excluding renderD and card*- child nodes that share the same driver.
To keep an explicit ordering without the unstable cardN name, the rule also publishes SYSTEMD_ALIAS=/dev/dri/msm_dpu_card, exposing the node as the stable device unit dev-dri-msm_dpu_card.device; weston.service orders itself with Requires=/After=dev-dri-msm_dpu_card.device.
Verified on rb3gen2-core-kit: card0's parent display-controller driver is msm_dpu, the rule matches only the card0 minor (not renderD128 or the DP/HDMI connector nodes), the alias device unit comes up active, and the service loads with the alias dependency.